Messages in this thread | | | Date | Thu, 15 Jul 2021 16:58:31 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 05/20] perf test: event_update: fix memory leak of unit |
| |
Em Thu, Jul 15, 2021 at 06:07:10PM +0200, Riccardo Mancini escreveu: > ASan reports a memory leak while running the perf test > "49: Synthesize attr update" caused by a string being duplicated but > never freed. > > This patch adds the missing free(). > > Note that evsel->unit is not deallocated together with evsel since it > is supposed to be a constant string.
Thanks, applied and added the Fixes tag, which I'm doing to all the patches in the series.
- Arnaldo
> Signed-off-by: Riccardo Mancini <rickyman7@gmail.com> > --- > tools/perf/tests/event_update.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/tests/event_update.c b/tools/perf/tests/event_update.c > index 932ab0740d11ced6..44a50527f9d95170 100644 > --- a/tools/perf/tests/event_update.c > +++ b/tools/perf/tests/event_update.c > @@ -88,6 +88,7 @@ int test__event_update(struct test *test __maybe_unused, int subtest __maybe_unu > struct evsel *evsel; > struct event_name tmp; > struct evlist *evlist = evlist__new_default(); > + char *unit = strdup("KRAVA"); > > TEST_ASSERT_VAL("failed to get evlist", evlist); > > @@ -98,7 +99,7 @@ int test__event_update(struct test *test __maybe_unused, int subtest __maybe_unu > > perf_evlist__id_add(&evlist->core, &evsel->core, 0, 0, 123); > > - evsel->unit = strdup("KRAVA"); > + evsel->unit = unit; > > TEST_ASSERT_VAL("failed to synthesize attr update unit", > !perf_event__synthesize_event_update_unit(NULL, evsel, process_event_unit)); > @@ -118,6 +119,7 @@ int test__event_update(struct test *test __maybe_unused, int subtest __maybe_unu > TEST_ASSERT_VAL("failed to synthesize attr update cpus", > !perf_event__synthesize_event_update_cpus(&tmp.tool, evsel, process_event_cpus)); > > + free(unit); > evlist__delete(evlist); > return 0; > } > -- > 2.31.1 >
--
- Arnaldo
| |