lkml.org 
[lkml]   [2021]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 143/242] Bluetooth: mgmt: Fix the command returns garbage parameter value
    Date
    From: Tedd Ho-Jeong An <tedd.an@intel.com>

    [ Upstream commit 02ce2c2c24024aade65a8d91d6a596651eaf2d0a ]

    When the Get Device Flags command fails, it returns the error status
    with the parameters filled with the garbage values. Although the
    parameters are not used, it is better to fill with zero than the random
    values.

    Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/bluetooth/mgmt.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
    index 06e24b5e164d..b4f6773b1a5b 100644
    --- a/net/bluetooth/mgmt.c
    +++ b/net/bluetooth/mgmt.c
    @@ -4056,6 +4056,8 @@ static int get_device_flags(struct sock *sk, struct hci_dev *hdev, void *data,

    hci_dev_lock(hdev);

    + memset(&rp, 0, sizeof(rp));
    +
    if (cp->addr.type == BDADDR_BREDR) {
    br_params = hci_bdaddr_list_lookup_with_flags(&hdev->whitelist,
    &cp->addr.bdaddr,
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-15 21:18    [W:4.065 / U:0.476 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site