lkml.org 
[lkml]   [2021]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 065/242] net: mscc: ocelot: check return value after calling platform_get_resource()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit f1fe19c2cb3fdc92a614cf330ced1613f8f1a681 ]

    It will cause null-ptr-deref if platform_get_resource() returns NULL,
    we need check the return value.

    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/dsa/ocelot/seville_vsc9953.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/net/dsa/ocelot/seville_vsc9953.c b/drivers/net/dsa/ocelot/seville_vsc9953.c
    index 84f93a874d50..deae923c8b7a 100644
    --- a/drivers/net/dsa/ocelot/seville_vsc9953.c
    +++ b/drivers/net/dsa/ocelot/seville_vsc9953.c
    @@ -1206,6 +1206,11 @@ static int seville_probe(struct platform_device *pdev)
    felix->info = &seville_info_vsc9953;

    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    + if (!res) {
    + err = -EINVAL;
    + dev_err(&pdev->dev, "Invalid resource\n");
    + goto err_alloc_felix;
    + }
    felix->switch_base = res->start;

    ds = kzalloc(sizeof(struct dsa_switch), GFP_KERNEL);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-15 21:10    [W:4.142 / U:0.532 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site