lkml.org 
[lkml]   [2021]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 023/242] net/sched: cls_api: increase max_reclassify_loop
    Date
    From: Davide Caratti <dcaratti@redhat.com>

    [ Upstream commit 05ff8435e50569a0a6b95e5ceaea43696e8827ab ]

    modern userspace applications, like OVN, can configure the TC datapath to
    "recirculate" packets several times. If more than 4 "recirculation" rules
    are configured, packets can be dropped by __tcf_classify().
    Changing the maximum number of reclassifications (from 4 to 16) should be
    sufficient to prevent drops in most use cases, and guard against loops at
    the same time.

    Signed-off-by: Davide Caratti <dcaratti@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/sched/cls_api.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
    index 94f6942d7ec1..2f82ac7c0f93 100644
    --- a/net/sched/cls_api.c
    +++ b/net/sched/cls_api.c
    @@ -1531,7 +1531,7 @@ static inline int __tcf_classify(struct sk_buff *skb,
    u32 *last_executed_chain)
    {
    #ifdef CONFIG_NET_CLS_ACT
    - const int max_reclassify_loop = 4;
    + const int max_reclassify_loop = 16;
    const struct tcf_proto *first_tp;
    int limit = 0;

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-15 21:10    [W:4.217 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site