lkml.org 
[lkml]   [2021]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 135/215] ath11k: unlock on error path in ath11k_mac_op_add_interface()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 59ec8e2fa5aaed6afd18d5362dc131aab92406e7 upstream.

    These error paths need to drop the &ar->conf_mutex before returning.

    Fixes: 690ace20ff79 ("ath11k: peer delete synchronization with firmware")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/X85sVGVP/0XvlrEJ@mwanda
    Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro1.iwamatsu@toshiba.co.jp>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/ath/ath11k/mac.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/wireless/ath/ath11k/mac.c
    +++ b/drivers/net/wireless/ath/ath11k/mac.c
    @@ -4603,13 +4603,13 @@ err_peer_del:
    if (ret) {
    ath11k_warn(ar->ab, "failed to delete peer vdev_id %d addr %pM\n",
    arvif->vdev_id, vif->addr);
    - return ret;
    + goto err;
    }

    ret = ath11k_wait_for_peer_delete_done(ar, arvif->vdev_id,
    vif->addr);
    if (ret)
    - return ret;
    + goto err;

    ar->num_peers--;
    }

    \
     
     \ /
      Last update: 2021-07-15 21:09    [W:3.766 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site