lkml.org 
[lkml]   [2021]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 050/215] RDMA/cxgb4: Fix missing error code in create_qp()
    Date
    From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

    [ Upstream commit aeb27bb76ad8197eb47890b1ff470d5faf8ec9a5 ]

    The error code is missing in this code scenario so 0 will be returned. Add
    the error code '-EINVAL' to the return value 'ret'.

    Eliminates the follow smatch warning:

    drivers/infiniband/hw/cxgb4/qp.c:298 create_qp() warn: missing error code 'ret'.

    Link: https://lore.kernel.org/r/1622545669-20625-1-git-send-email-jiapeng.chong@linux.alibaba.com
    Reported-by: Abaci Robot <abaci@linux.alibaba.com>
    Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/cxgb4/qp.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
    index 5df4bb52bb10..861e19fdfeb4 100644
    --- a/drivers/infiniband/hw/cxgb4/qp.c
    +++ b/drivers/infiniband/hw/cxgb4/qp.c
    @@ -295,6 +295,7 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq,
    if (user && (!wq->sq.bar2_pa || (need_rq && !wq->rq.bar2_pa))) {
    pr_warn("%s: sqid %u or rqid %u not in BAR2 range\n",
    pci_name(rdev->lldi.pdev), wq->sq.qid, wq->rq.qid);
    + ret = -EINVAL;
    goto free_dma;
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-15 20:51    [W:4.772 / U:1.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site