lkml.org 
[lkml]   [2021]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.13 069/108] i3c: master: svc: drop free_irq of devm_request_irq allocated irq
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit 59a61e69c4252b4e8ecd15e752b0d2337f0121b7 ]

    irq allocated with devm_request_irq() will be freed in devm_irq_release(),
    using free_irq() in ->remove() will causes a dangling pointer, and a
    subsequent double free. So remove the free_irq() in svc_i3c_master_remove().

    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    Link: https://lore.kernel.org/r/20210602084935.3977636-1-yangyingliang@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/i3c/master/svc-i3c-master.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
    index 1f6ba4221817..eeb49b5d90ef 100644
    --- a/drivers/i3c/master/svc-i3c-master.c
    +++ b/drivers/i3c/master/svc-i3c-master.c
    @@ -1448,7 +1448,6 @@ static int svc_i3c_master_remove(struct platform_device *pdev)
    if (ret)
    return ret;

    - free_irq(master->irq, master);
    clk_disable_unprepare(master->pclk);
    clk_disable_unprepare(master->fclk);
    clk_disable_unprepare(master->sclk);
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-14 21:45    [W:4.142 / U:0.536 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site