lkml.org 
[lkml]   [2021]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch v3 2/3] Drivers: hv: add Azure Blob driver
One final thing:

On Tue, Jul 13, 2021 at 07:45:21PM -0700, longli@linuxonhyperv.com wrote:
> +#define az_blob_dbg(fmt, args...) dev_dbg(&az_blob_dev.device->device, fmt, ##args)
> +#define az_blob_info(fmt, args...) dev_info(&az_blob_dev.device->device, fmt, ##args)
> +#define az_blob_warn(fmt, args...) dev_warn(&az_blob_dev.device->device, fmt, ##args)
> +#define az_blob_err(fmt, args...) dev_err(&az_blob_dev.device->device, fmt, ##args)

This tiny driver does not deserve a different loging scheme from all of
the rest of the kernel. Just use the dev_* calls directly please, no
need to try to roll your own. Especially for a 600 line file.

And remove your calls to az_blob_info() that are just debugging stuff,
when the driver is working properly, it is quiet.

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-07-14 19:26    [W:0.151 / U:1.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site