Messages in this thread Patch in this message | | | From | John Garry <> | Subject | [PATCH 5/9] blk-mq: Invert check in blk_mq_update_nr_requests() | Date | Wed, 14 Jul 2021 23:06:31 +0800 |
| |
It's easier to read:
if (x) X; else Y;
over:
if (!x) Y; else X;
No functional change intended.
Signed-off-by: John Garry <john.garry@huawei.com> --- block/blk-mq.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c index b0d4197d36c7..3ff5c15ce0eb 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -3621,18 +3621,18 @@ int blk_mq_update_nr_requests(struct request_queue *q, unsigned int nr) * If we're using an MQ scheduler, just update the scheduler * queue depth. This is similar to what the old code would do. */ - if (!hctx->sched_tags) { - ret = blk_mq_tag_update_depth(hctx, &hctx->tags, nr, - false); - } else { + if (hctx->sched_tags) { ret = blk_mq_tag_update_depth(hctx, &hctx->sched_tags, - nr, true); + nr, true); if (blk_mq_is_sbitmap_shared(set->flags)) { hctx->sched_tags->bitmap_tags = &q->sched_bitmap_tags; hctx->sched_tags->breserved_tags = &q->sched_breserved_tags; } + } else { + ret = blk_mq_tag_update_depth(hctx, &hctx->tags, nr, + false); } if (ret) break; -- 2.26.2
| |