Messages in this thread | | | Date | Wed, 14 Jul 2021 08:22:42 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: cocci script to convert linux-kernel allocs with BITS_TO_LONGS to bitmap_alloc |
| |
On Tue, 13 Jul 2021, Joe Perches wrote:
> On Tue, 2021-07-13 at 23:33 +0200, Julia Lawall wrote: > > > > On Fri, 9 Jul 2021, Joe Perches wrote: > > > > > Here is a cocci script to convert various types of bitmap allocations > > > > > that use BITS_TO_LONGS to the more typical bitmap_alloc functions. > > > > I see that there is also a bitmap_free. Maybe the rule should be > > introducing that as well? > > Yes, but as far as I know, it's difficult for coccinelle to convert > the kfree() calls of any previous bitmap_alloc to bitmap_free as > most frequently the kfree() call is in a separate function.
Often the code says a->b = foo(); and then the a->b in another function is the same one that was the result of foo(). One could check that this is the only assignment to a->b in the file for more confidence.
I'll add it to the rule and see how it goes.
julia
> > Please do it if you know how, you're probably the best in the world > at coccinelle. I don't know how... > > cheers, Joe > >
| |