Messages in this thread | | | Date | Wed, 14 Jul 2021 13:22:46 +0200 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH v5 4/8] dt-bindings: PCI: kirin: Drop PHY properties |
| |
Em Tue, 13 Jul 2021 20:28:49 -0600 Rob Herring <robh@kernel.org> escreveu:
> On Tue, Jul 13, 2021 at 08:28:37AM +0200, Mauro Carvalho Chehab wrote: > > There are several properties there that belong to the PHY > > interface. Drop them, as a new binding file will describe > > the PHY properties for Kirin 960. > > Folks are okay with an incompatible change on hikey960?
I hope so ;-)
I mean, it should be easy to add a backward-compatible code that would make the PHY driver to use the pci-bus old schema if there's no PHY entry at DT.
However, this is not enough, as the PHY driver won't be loaded/probed without at least this at hi3660.dtsi:
pcie_phy: pcie-phy@f3f2000 { compatible = "hisilicon,hi960-pcie-phy"; };
So, some (probably ugly) hack would be needed at pcie-kirin, in order to make it to manually load and probe the PHY driver, if it founds (for instance) "phy" reg-name as a pcie-kirin property.
Thanks, Mauro
| |