Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH v13 010/137] mm: Add folio flag manipulation functions | Date | Wed, 14 Jul 2021 10:18:55 +0100 |
| |
Johannes Weiner <hannes@cmpxchg.org> wrote:
> For example, in __set_page_dirty_no_writeback() > > if (folio_is_dirty()) > return !folio_testset_dirty() > > is less clear about what's going on than would be: > > if (folio_test_dirty()) > return !folio_testset_dirty()
"if (folio_is_dirty())" reads better to me as that's more or less how you'd structure a sentence beginning with "if" in English.
On the other hand, folio_test_xxx() fits in with a folio_testset_xxx() naming style. English doesn't really have test-and-set operator words.
David
| |