lkml.org 
[lkml]   [2021]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1, 04/14] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings
On Thu, Jul 08, 2021 at 06:04:54PM +0800, Tzung-Bi Shih wrote:
> On Wed, Jul 7, 2021 at 2:22 PM Yunfei Dong <yunfei.dong@mediatek.com> wrote:
> > .../media/mediatek-vcodec-decoder.txt | 169 ++++++++++++++++++
> > .../media/mediatek-vcodec-encoder.txt | 73 ++++++++
> > 2 files changed, 242 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-decoder.txt
> > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-encoder.txt
> The patch is weird. Its title says "separate" but the changes are all
> creating new content.
>
> Would expect the patch to remove content from some files (e.g.
> Documentation/devicetree/bindings/media/mediatek-vcodec.txt) and
> separate into 2 files.

Except h/w doesn't change. Using the component framework is not a reason
to change bindings.

Also, note that any major changes or additions should be in schema
format now.

Rob

\
 
 \ /
  Last update: 2021-07-15 01:15    [W:0.063 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site