Messages in this thread | | | Date | Tue, 13 Jul 2021 19:59:29 +0000 | From | Sean Christopherson <> | Subject | Re: [RFC PATCH v2 09/69] KVM: TDX: Add C wrapper functions for TDX SEAMCALLs |
| |
On Tue, Jul 06, 2021, Paolo Bonzini wrote: > On 03/07/21 00:04, isaku.yamahata@intel.com wrote: > > +static inline u64 tdh_mng_addcx(hpa_t tdr, hpa_t addr) > > +{ > > + return seamcall(TDH_MNG_ADDCX, addr, tdr, 0, 0, 0, NULL); > > +} > > + > > Since you have wrappers anyway, I don't like having an extra macro level > just to remove the SEAMCALL_ prefix. It messes up editors that look up the > symbols.
True. On the other hand, prefixing SEAMCALL_ over and over is tedious and adds a lot of noise. What if we drop SEAMCALL_ from the #defines? The prefix made sense when there was no additional namespace, e.g. instead of having a bare TDCREATE, but that's mostly a non-issue now that all the SEAMCALLs are namespaced with TDH_.
| |