lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 578/593] csky: fix syscache.c fallthrough warning
    Date
    From: Randy Dunlap <rdunlap@infradead.org>

    [ Upstream commit 0679d29d3e2351a1c3049c26a63ce1959cad5447 ]

    This case of the switch statement falls through to the following case.
    This appears to be on purpose, so declare it as OK.

    ../arch/csky/mm/syscache.c: In function '__do_sys_cacheflush':
    ../arch/csky/mm/syscache.c:17:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
    17 | flush_icache_mm_range(current->mm,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    18 | (unsigned long)addr,
    | ~~~~~~~~~~~~~~~~~~~~
    19 | (unsigned long)addr + bytes);
    | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../arch/csky/mm/syscache.c:20:2: note: here
    20 | case DCACHE:
    | ^~~~

    Fixes: 997153b9a75c ("csky: Add flush_icache_mm to defer flush icache all")
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Signed-off-by: Guo Ren <guoren@kernel.org>
    Cc: linux-csky@vger.kernel.org
    Cc: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/csky/mm/syscache.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/csky/mm/syscache.c b/arch/csky/mm/syscache.c
    index ffade2f9a4c8..4e51d63850c4 100644
    --- a/arch/csky/mm/syscache.c
    +++ b/arch/csky/mm/syscache.c
    @@ -17,6 +17,7 @@ SYSCALL_DEFINE3(cacheflush,
    flush_icache_mm_range(current->mm,
    (unsigned long)addr,
    (unsigned long)addr + bytes);
    + fallthrough;
    case DCACHE:
    dcache_wb_range((unsigned long)addr,
    (unsigned long)addr + bytes);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 09:17    [W:4.057 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site