lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 367/593] samples/bpf: Fix the error return code of xdp_redirects main()
    Date
    From: Wang Hai <wanghai38@huawei.com>

    [ Upstream commit 7c6090ee2a7b3315410cfc83a94c3eb057407b25 ]

    Fix to return a negative error code from the error handling
    case instead of 0, as done elsewhere in this function.

    If bpf_map_update_elem() failed, main() should return a negative error.

    Fixes: 832622e6bd18 ("xdp: sample program for new bpf_redirect helper")
    Signed-off-by: Wang Hai <wanghai38@huawei.com>
    Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
    Link: https://lore.kernel.org/bpf/20210616042534.315097-1-wanghai38@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    samples/bpf/xdp_redirect_user.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/samples/bpf/xdp_redirect_user.c b/samples/bpf/xdp_redirect_user.c
    index 1ddac4bcf447..3c92adc2a7bd 100644
    --- a/samples/bpf/xdp_redirect_user.c
    +++ b/samples/bpf/xdp_redirect_user.c
    @@ -219,5 +219,5 @@ int main(int argc, char **argv)
    poll_stats(2, ifindex_out);

    out:
    - return 0;
    + return ret;
    }
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 09:01    [W:4.062 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site