lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 256/348] tty: nozomi: Fix a resource leak in an error handling function
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 31a9a318255960d32ae183e95d0999daf2418608 ]

    A 'request_irq()' call is not balanced by a corresponding 'free_irq()' in
    the error handling path, as already done in the remove function.

    Add it.

    Fixes: 9842c38e9176 ("kfifo: fix warn_unused_result")
    Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Link: https://lore.kernel.org/r/4f0d2b3038e82f081d370ccb0cade3ad88463fe7.1620580838.git.christophe.jaillet@wanadoo.fr
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/nozomi.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
    index ed99948f3b7f..50590e50c3fe 100644
    --- a/drivers/tty/nozomi.c
    +++ b/drivers/tty/nozomi.c
    @@ -1437,6 +1437,7 @@ err_free_tty:
    tty_unregister_device(ntty_driver, dc->index_start + i);
    tty_port_destroy(&dc->port[i].port);
    }
    + free_irq(pdev->irq, dc);
    err_free_kfifo:
    for (i = 0; i < MAX_PORT; i++)
    kfifo_free(&dc->port[i].fifo_ul);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 08:40    [W:2.184 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site