lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 264/348] iio:accel:mxc4005: Drop unnecessary explicit casts in regmap_bulk_read calls
    Date
    From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

    [ Upstream commit b01401a228bc4997b0d4bcb669fced448f7a15ca ]

    regmap_bulk_read takes a void * for its val parameter. It certainly
    makes no sense to cast to a (u8 *) + no need to explicitly cast
    at all when converting another pointer type to void *.

    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
    Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/iio/accel/mxc4005.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/iio/accel/mxc4005.c b/drivers/iio/accel/mxc4005.c
    index 3d5bea651923..9d07642c0de1 100644
    --- a/drivers/iio/accel/mxc4005.c
    +++ b/drivers/iio/accel/mxc4005.c
    @@ -135,7 +135,7 @@ static int mxc4005_read_xyz(struct mxc4005_data *data)
    int ret;

    ret = regmap_bulk_read(data->regmap, MXC4005_REG_XOUT_UPPER,
    - (u8 *) data->buffer, sizeof(data->buffer));
    + data->buffer, sizeof(data->buffer));
    if (ret < 0) {
    dev_err(data->dev, "failed to read axes\n");
    return ret;
    @@ -150,7 +150,7 @@ static int mxc4005_read_axis(struct mxc4005_data *data,
    __be16 reg;
    int ret;

    - ret = regmap_bulk_read(data->regmap, addr, (u8 *) &reg, sizeof(reg));
    + ret = regmap_bulk_read(data->regmap, addr, &reg, sizeof(reg));
    if (ret < 0) {
    dev_err(data->dev, "failed to read reg %02x\n", addr);
    return ret;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 08:40    [W:4.121 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site