Messages in this thread | | | Date | Mon, 12 Jul 2021 16:07:44 -0600 | From | Alex Williamson <> | Subject | Re: [PATCH v10 1/8] PCI: Add pcie_reset_flr to follow calling convention of other reset methods |
| |
On Fri, 9 Jul 2021 18:08:06 +0530 Amey Narkhede <ameynarkhede03@gmail.com> wrote:
> Add has_pcie_flr bitfield in struct pci_dev to indicate support for PCIe > FLR to avoid reading PCI_EXP_DEVCAP multiple times. > > Currently there is separate function pcie_has_flr() to probe if PCIe FLR > is supported by the device which does not match the calling convention > followed by reset methods which use second function argument to decide > whether to probe or not. Add new function pcie_reset_flr() that follows > the calling convention of reset methods. > > Signed-off-by: Amey Narkhede <ameynarkhede03@gmail.com> > --- > drivers/crypto/cavium/nitrox/nitrox_main.c | 4 +- > drivers/pci/pci.c | 59 +++++++++++----------- > drivers/pci/pcie/aer.c | 12 ++--- > drivers/pci/probe.c | 6 ++- > drivers/pci/quirks.c | 9 ++-- > include/linux/pci.h | 3 +- > 6 files changed, 45 insertions(+), 48 deletions(-)
Looks good to me,
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
| |