| From | Greg Kroah-Hartman <> | Subject | [PATCH 5.4 341/348] mm/z3fold: fix potential memory leak in z3fold_destroy_pool() | Date | Mon, 12 Jul 2021 08:12:05 +0200 |
| |
From: Miaohe Lin <linmiaohe@huawei.com>
[ Upstream commit dac0d1cfda56472378d330b1b76b9973557a7b1d ]
There is a memory leak in z3fold_destroy_pool() as it forgets to free_percpu pool->unbuddied. Call free_percpu for pool->unbuddied to fix this issue.
Link: https://lkml.kernel.org/r/20210619093151.1492174-6-linmiaohe@huawei.com Fixes: d30561c56f41 ("z3fold: use per-cpu unbuddied lists") Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Reviewed-by: Vitaly Wool <vitaly.wool@konsulko.com> Cc: Hillf Danton <hdanton@sina.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- mm/z3fold.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/mm/z3fold.c b/mm/z3fold.c index 6d3d3f698ebb..e97143713021 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -839,6 +839,7 @@ static void z3fold_destroy_pool(struct z3fold_pool *pool) destroy_workqueue(pool->compact_wq); destroy_workqueue(pool->release_wq); z3fold_unregister_migration(pool); + free_percpu(pool->unbuddied); kfree(pool); } -- 2.30.2
|