Messages in this thread | | | Date | Mon, 12 Jul 2021 16:57:35 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/1] pps: generators: pps_gen_parport: Switch to use module_parport_driver() |
| |
On Wed, Jun 16, 2021 at 04:44:38PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jun 16, 2021 at 05:31:21PM +0300, Andy Shevchenko wrote: > > Switch to use module_parport_driver() to reduce boilerplate code.
> > + pr_info("hrtimer avg error is %ldns\n", hrtimer_error); > > Why is this line needed? When drivers work properly, they are quiet. > > I know the existing code has it, no reason it needs to stay here, that's > why we created these macros, to remove the ability for drivers to be > printing junk like this that they do not need to be printing.
Seems the original authors keeps silent. What do you suggest in this case? Remove the line and resubmit?
-- With Best Regards, Andy Shevchenko
| |