lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 456/800] ieee802154: hwsim: Fix possible memory leak in hwsim_subscribe_all_others
    Date
    From: Dongliang Mu <mudongliangabcd@gmail.com>

    [ Upstream commit ab372c2293f5d0b279f31c8d768566ea37602dc9 ]

    In hwsim_subscribe_all_others, the error handling code performs
    incorrectly if the second hwsim_alloc_edge fails. When this issue occurs,
    it goes to sub_fail, without cleaning the edges allocated before.

    Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb")
    Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
    Acked-by: Alexander Aring <aahringo@redhat.com>
    Link: https://lore.kernel.org/r/20210611015812.1626999-1-mudongliangabcd@gmail.com
    Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ieee802154/mac802154_hwsim.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
    index da9135231c07..366eaae3550a 100644
    --- a/drivers/net/ieee802154/mac802154_hwsim.c
    +++ b/drivers/net/ieee802154/mac802154_hwsim.c
    @@ -715,6 +715,8 @@ static int hwsim_subscribe_all_others(struct hwsim_phy *phy)

    return 0;

    +sub_fail:
    + hwsim_edge_unsubscribe_me(phy);
    me_fail:
    rcu_read_lock();
    list_for_each_entry_rcu(e, &phy->edges, list) {
    @@ -722,8 +724,6 @@ me_fail:
    hwsim_free_edge(e);
    }
    rcu_read_unlock();
    -sub_fail:
    - hwsim_edge_unsubscribe_me(phy);
    return -ENOMEM;
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 11:10    [W:4.079 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site