lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 709/800] iio: adc: at91-sama5d2: Fix buffer alignment in iio_push_to_buffers_with_timestamp()
    Date
    From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

    [ Upstream commit 8f884758966259fa8c50c137ac6d4ce9bb7859db ]

    To make code more readable, use a structure to express the channel
    layout and ensure the timestamp is 8 byte aligned.

    Found during an audit of all calls of this function.

    Fixes: 5e1a1da0f8c9 ("iio: adc: at91-sama5d2_adc: add hw trigger and buffer support")
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Cc: Eugen Hristev <eugen.hristev@microchip.com>
    Reviewed-by: Nuno Sá <nuno.sa@analog.com>
    Link: https://lore.kernel.org/r/20210613152301.571002-2-jic23@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/iio/adc/at91-sama5d2_adc.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
    index a7826f097b95..d356b515df09 100644
    --- a/drivers/iio/adc/at91-sama5d2_adc.c
    +++ b/drivers/iio/adc/at91-sama5d2_adc.c
    @@ -403,7 +403,8 @@ struct at91_adc_state {
    struct at91_adc_dma dma_st;
    struct at91_adc_touch touch_st;
    struct iio_dev *indio_dev;
    - u16 buffer[AT91_BUFFER_MAX_HWORDS];
    + /* Ensure naturally aligned timestamp */
    + u16 buffer[AT91_BUFFER_MAX_HWORDS] __aligned(8);
    /*
    * lock to prevent concurrent 'single conversion' requests through
    * sysfs.
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 11:10    [W:4.114 / U:0.460 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site