lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 711/800] iio: adc: mxs-lradc: Fix buffer alignment in iio_push_to_buffers_with_timestamp()
    Date
    From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

    [ Upstream commit 6a6be221b8bd561b053f0701ec752a5ed9007f69 ]

    To make code more readable, use a structure to express the channel
    layout and ensure the timestamp is 8 byte aligned.
    Add a comment on why the buffer is the size it is as not immediately
    obvious.

    Found during an audit of all calls of this function.

    Fixes: 6dd112b9f85e ("iio: adc: mxs-lradc: Add support for ADC driver")
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Cc: Andreas Klinger <ak@it-klinger.de>
    Reviewed-by: Nuno Sá <nuno.sa@analog.com>
    Link: https://lore.kernel.org/r/20210613152301.571002-4-jic23@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/iio/adc/mxs-lradc-adc.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c
    index 30e29f44ebd2..c480cb489c1a 100644
    --- a/drivers/iio/adc/mxs-lradc-adc.c
    +++ b/drivers/iio/adc/mxs-lradc-adc.c
    @@ -115,7 +115,8 @@ struct mxs_lradc_adc {
    struct device *dev;

    void __iomem *base;
    - u32 buffer[10];
    + /* Maximum of 8 channels + 8 byte ts */
    + u32 buffer[10] __aligned(8);
    struct iio_trigger *trig;
    struct completion completion;
    spinlock_t lock;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 11:10    [W:2.386 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site