lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 783/800] scsi: fc: Correct RHBA attributes length
    Date
    From: Javed Hasan <jhasan@marvell.com>

    commit 40445fd2c9fa427297acdfcc2c573ff10493f209 upstream.

    As per the FC-GS-5 specification, attribute lengths of node_name and
    manufacturer should in range of "4 to 64 Bytes" only.

    Link: https://lore.kernel.org/r/20210603101404.7841-2-jhasan@marvell.com
    Fixes: e721eb0616f6 ("scsi: scsi_transport_fc: Match HBA Attribute Length with HBAAPI V2.0 definitions")
    CC: stable@vger.kernel.org
    Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
    Signed-off-by: Javed Hasan <jhasan@marvell.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    include/scsi/fc/fc_ms.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/include/scsi/fc/fc_ms.h
    +++ b/include/scsi/fc/fc_ms.h
    @@ -63,8 +63,8 @@ enum fc_fdmi_hba_attr_type {
    * HBA Attribute Length
    */
    #define FC_FDMI_HBA_ATTR_NODENAME_LEN 8
    -#define FC_FDMI_HBA_ATTR_MANUFACTURER_LEN 80
    -#define FC_FDMI_HBA_ATTR_SERIALNUMBER_LEN 80
    +#define FC_FDMI_HBA_ATTR_MANUFACTURER_LEN 64
    +#define FC_FDMI_HBA_ATTR_SERIALNUMBER_LEN 64
    #define FC_FDMI_HBA_ATTR_MODEL_LEN 256
    #define FC_FDMI_HBA_ATTR_MODELDESCR_LEN 256
    #define FC_FDMI_HBA_ATTR_HARDWAREVERSION_LEN 256

    \
     
     \ /
      Last update: 2021-07-12 11:10    [W:2.342 / U:0.940 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site