lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 613/800] iio: adis_buffer: do not return ints in irq handlers
    Date
    From: Nuno Sa <nuno.sa@analog.com>

    [ Upstream commit d877539ad8e8fdde9af69887055fec6402be1a13 ]

    On an IRQ handler we should not return normal error codes as 'irqreturn_t'
    is expected.

    Not necessarily stable material as the old check cannot fail, so it's a bug
    we can not hit.

    Fixes: ccd2b52f4ac69 ("staging:iio: Add common ADIS library")
    Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
    Signed-off-by: Nuno Sa <nuno.sa@analog.com>
    Link: https://lore.kernel.org/r/20210422101911.135630-2-nuno.sa@analog.com
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/iio/imu/adis_buffer.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/drivers/iio/imu/adis_buffer.c b/drivers/iio/imu/adis_buffer.c
    index ac354321f63a..175af154e443 100644
    --- a/drivers/iio/imu/adis_buffer.c
    +++ b/drivers/iio/imu/adis_buffer.c
    @@ -129,9 +129,6 @@ static irqreturn_t adis_trigger_handler(int irq, void *p)
    struct adis *adis = iio_device_get_drvdata(indio_dev);
    int ret;

    - if (!adis->buffer)
    - return -ENOMEM;
    -
    if (adis->data->has_paging) {
    mutex_lock(&adis->state_lock);
    if (adis->current_page != 0) {
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 11:10    [W:4.087 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site