lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 654/800] leds: class: The -ENOTSUPP should never be seen by user space
    Date
    From: Andy Shevchenko <andy.shevchenko@gmail.com>

    [ Upstream commit 0ac40af86077982a5346dbc9655172d2775d6b08 ]

    Drop the bogus error code and let of_led_get() to take care about absent
    of_node.

    Fixes: e389240ad992 ("leds: Add managed API to get a LED from a device driver")
    Cc: Jean-Jacques Hiblot <jjhiblot@ti.com>
    Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    Signed-off-by: Pavel Machek <pavel@ucw.cz>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/leds/led-class.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
    index 2e495ff67856..fa3f5f504ff7 100644
    --- a/drivers/leds/led-class.c
    +++ b/drivers/leds/led-class.c
    @@ -285,10 +285,6 @@ struct led_classdev *__must_check devm_of_led_get(struct device *dev,
    if (!dev)
    return ERR_PTR(-EINVAL);

    - /* Not using device tree? */
    - if (!IS_ENABLED(CONFIG_OF) || !dev->of_node)
    - return ERR_PTR(-ENOTSUPP);
    -
    led = of_led_get(dev->of_node, index);
    if (IS_ERR(led))
    return led;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 11:10    [W:4.016 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site