lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 449/800] drm: qxl: ensure surf.data is ininitialized
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit fbbf23ddb2a1cc0c12c9f78237d1561c24006f50 ]

    The object surf is not fully initialized and the uninitialized
    field surf.data is being copied by the call to qxl_bo_create
    via the call to qxl_gem_object_create. Set surf.data to zero
    to ensure garbage data from the stack is not being copied.

    Addresses-Coverity: ("Uninitialized scalar variable")
    Fixes: f64122c1f6ad ("drm: add new QXL driver. (v1.4)")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Link: http://patchwork.freedesktop.org/patch/msgid/20210608161313.161922-1-colin.king@canonical.com
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/qxl/qxl_dumb.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/gpu/drm/qxl/qxl_dumb.c b/drivers/gpu/drm/qxl/qxl_dumb.c
    index 48a58ba1db96..686485b19d0f 100644
    --- a/drivers/gpu/drm/qxl/qxl_dumb.c
    +++ b/drivers/gpu/drm/qxl/qxl_dumb.c
    @@ -58,6 +58,8 @@ int qxl_mode_dumb_create(struct drm_file *file_priv,
    surf.height = args->height;
    surf.stride = pitch;
    surf.format = format;
    + surf.data = 0;
    +
    r = qxl_gem_object_create_with_handle(qdev, file_priv,
    QXL_GEM_DOMAIN_CPU,
    args->size, &surf, &qobj,
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 11:10    [W:2.227 / U:0.440 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site