lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 526/800] net: mana: Fix a memory leak in an error handling path in mana_create_txq()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit b90788459cd6d140171b046f0b37fad341ade0a3 ]

    If this test fails we must free some resources as in all the other error
    handling paths of this function.

    Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Reviewed-by: Dexuan Cui <decui@microsoft.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/microsoft/mana/mana_en.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
    index 04d067243457..1ed25e48f616 100644
    --- a/drivers/net/ethernet/microsoft/mana/mana_en.c
    +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
    @@ -1230,8 +1230,10 @@ static int mana_create_txq(struct mana_port_context *apc,

    cq->gdma_id = cq->gdma_cq->id;

    - if (WARN_ON(cq->gdma_id >= gc->max_num_cqs))
    - return -EINVAL;
    + if (WARN_ON(cq->gdma_id >= gc->max_num_cqs)) {
    + err = -EINVAL;
    + goto out;
    + }

    gc->cq_table[cq->gdma_id] = cq->gdma_cq;

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 11:10    [W:4.039 / U:0.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site