lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 510/800] net: ethernet: ezchip: fix UAF in nps_enet_remove
    Date
    From: Pavel Skripkin <paskripkin@gmail.com>

    [ Upstream commit e4b8700e07a86e8eab6916aa5c5ba99042c34089 ]

    priv is netdev private data, but it is used
    after free_netdev(). It can cause use-after-free when accessing priv
    pointer. So, fix it by moving free_netdev() after netif_napi_del()
    call.

    Fixes: 0dd077093636 ("NET: Add ezchip ethernet driver")
    Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/ezchip/nps_enet.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchip/nps_enet.c
    index e3954d8835e7..20d2c2bb26e4 100644
    --- a/drivers/net/ethernet/ezchip/nps_enet.c
    +++ b/drivers/net/ethernet/ezchip/nps_enet.c
    @@ -642,8 +642,8 @@ static s32 nps_enet_remove(struct platform_device *pdev)
    struct nps_enet_priv *priv = netdev_priv(ndev);

    unregister_netdev(ndev);
    - free_netdev(ndev);
    netif_napi_del(&priv->napi);
    + free_netdev(ndev);

    return 0;
    }
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 11:09    [W:2.380 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site