lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 745/800] ASoC: fsl_spdif: Fix unexpected interrupt after suspend
    Date
    From: Shengjiu Wang <shengjiu.wang@nxp.com>

    [ Upstream commit a7a0a2feb957e446b2bcf732f245ba04fc8b6314 ]

    When system enter suspend, the machine driver suspend callback
    function will be called, then the cpu driver trigger callback
    (SNDRV_PCM_TRIGGER_SUSPEND) be called, it would disable the
    interrupt.

    But the machine driver suspend and cpu dai driver suspend order
    maybe changed, the cpu dai driver's suspend callback is called before
    machine driver's suppend callback, then the interrupt is not cleared
    successfully in trigger callback.

    So need to clear interrupts in cpu dai driver's suspend callback
    to avoid such issue.

    Fixes: 9cb2b3796e08 ("ASoC: fsl_spdif: Add pm runtime function")
    Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
    Reviewed-by: Fabio Estevam <festevam@gmail.com>
    Link: https://lore.kernel.org/r/1624365084-7934-1-git-send-email-shengjiu.wang@nxp.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/fsl/fsl_spdif.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
    index 5636837eb511..53499bc71fa9 100644
    --- a/sound/soc/fsl/fsl_spdif.c
    +++ b/sound/soc/fsl/fsl_spdif.c
    @@ -1404,6 +1404,9 @@ static int fsl_spdif_runtime_suspend(struct device *dev)
    struct fsl_spdif_priv *spdif_priv = dev_get_drvdata(dev);
    int i;

    + /* Disable all the interrupts */
    + regmap_update_bits(spdif_priv->regmap, REG_SPDIF_SIE, 0xffffff, 0);
    +
    regmap_read(spdif_priv->regmap, REG_SPDIF_SRPC,
    &spdif_priv->regcache_srpc);
    regcache_cache_only(spdif_priv->regmap, true);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 11:04    [W:4.073 / U:0.612 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site