lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 730/800] habanalabs: Fix an error handling path in hl_pci_probe()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 3002f467a0b0a70aec01d9f446da4ac8c6fda10b ]

    If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
    must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
    call, as already done in the remove function.

    Fixes: 2e5eda4681f9 ("habanalabs: PCIe Advanced Error Reporting support")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
    Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/misc/habanalabs/common/habanalabs_drv.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/misc/habanalabs/common/habanalabs_drv.c b/drivers/misc/habanalabs/common/habanalabs_drv.c
    index 64d1530db985..d15b912a347b 100644
    --- a/drivers/misc/habanalabs/common/habanalabs_drv.c
    +++ b/drivers/misc/habanalabs/common/habanalabs_drv.c
    @@ -464,6 +464,7 @@ static int hl_pci_probe(struct pci_dev *pdev,
    return 0;

    disable_device:
    + pci_disable_pcie_error_reporting(pdev);
    pci_set_drvdata(pdev, NULL);
    destroy_hdev(hdev);

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 10:55    [W:4.130 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site