lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 368/800] extcon: extcon-max8997: Fix IRQ freeing at error path
    Date
    From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>

    [ Upstream commit 610bdc04830a864115e6928fc944f1171dfff6f3 ]

    If reading MAX8997_MUIC_REG_STATUS1 fails at probe the driver exits
    without freeing the requested IRQs.

    Free the IRQs prior returning if reading the status fails.

    Fixes: 3e34c8198960 ("extcon: max8997: Avoid forcing UART path on drive probe")
    Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
    Link: https://lore.kernel.org/r/27ee4a48ee775c3f8c9d90459c18b6f2b15edc76.1623146580.git.matti.vaittinen@fi.rohmeurope.com
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/extcon/extcon-max8997.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
    index e1408075ef7d..c15a612067af 100644
    --- a/drivers/extcon/extcon-max8997.c
    +++ b/drivers/extcon/extcon-max8997.c
    @@ -733,7 +733,7 @@ static int max8997_muic_probe(struct platform_device *pdev)
    2, info->status);
    if (ret) {
    dev_err(info->dev, "failed to read MUIC register\n");
    - return ret;
    + goto err_irq;
    }
    cable_type = max8997_muic_get_cable_type(info,
    MAX8997_CABLE_GROUP_ADC, &attached);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 10:45    [W:3.160 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site