lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 427/800] RDMA/hns: Fix wrong timer context buffer page size
    Date
    From: Xi Wang <wangxi11@huawei.com>

    [ Upstream commit 5e6370d7cc75134b0eb5b15916aab40b628db9e1 ]

    The HEM page size for QPC timer and CQC timer is always 4K and there's no
    need to calculate a different size by the hns driver, otherwise the ROCEE
    may access an invalid address.

    Fixes: 719d13415f59 ("RDMA/hns: Remove duplicated hem page size config code")
    Link: https://lore.kernel.org/r/1621589395-2435-4-git-send-email-liweihang@huawei.com
    Signed-off-by: Xi Wang <wangxi11@huawei.com>
    Signed-off-by: Weihang Li <liweihang@huawei.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 6 ------
    1 file changed, 6 deletions(-)

    diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
    index 49bb4f51466c..d7289b6587f1 100644
    --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
    +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
    @@ -2092,12 +2092,6 @@ static void set_hem_page_size(struct hns_roce_dev *hr_dev)
    calc_pg_sz(caps->max_cqes, caps->cqe_sz, caps->cqe_hop_num,
    1, &caps->cqe_buf_pg_sz, &caps->cqe_ba_pg_sz, HEM_TYPE_CQE);

    - if (caps->cqc_timer_entry_sz)
    - calc_pg_sz(caps->num_cqc_timer, caps->cqc_timer_entry_sz,
    - caps->cqc_timer_hop_num, caps->cqc_timer_bt_num,
    - &caps->cqc_timer_buf_pg_sz,
    - &caps->cqc_timer_ba_pg_sz, HEM_TYPE_CQC_TIMER);
    -
    /* SRQ */
    if (caps->flags & HNS_ROCE_CAP_FLAG_SRQ) {
    calc_pg_sz(caps->num_srqs, caps->srqc_entry_sz,
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 10:44    [W:3.498 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site