lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 029/800] usb: typec: Add the missed altmode_id_remove() in typec_register_altmode()
    Date
    From: Jing Xiangfeng <jingxiangfeng@huawei.com>

    commit 03026197bb657d784220b040c6173267a0375741 upstream.

    typec_register_altmode() misses to call altmode_id_remove() in an error
    path. Add the missed function call to fix it.

    Fixes: 8a37d87d72f0 ("usb: typec: Bus type for alternate modes")
    Cc: stable <stable@vger.kernel.org>
    Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
    Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
    Link: https://lore.kernel.org/r/20210617073226.47599-1-jingxiangfeng@huawei.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/typec/class.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/usb/typec/class.c
    +++ b/drivers/usb/typec/class.c
    @@ -517,8 +517,10 @@ typec_register_altmode(struct device *pa
    int ret;

    alt = kzalloc(sizeof(*alt), GFP_KERNEL);
    - if (!alt)
    + if (!alt) {
    + altmode_id_remove(parent, id);
    return ERR_PTR(-ENOMEM);
    + }

    alt->adev.svid = desc->svid;
    alt->adev.mode = desc->mode;

    \
     
     \ /
      Last update: 2021-07-12 10:41    [W:3.270 / U:0.928 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site