lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 363/800] mark pstore-blk as broken
    Date
    From: Christoph Hellwig <hch@lst.de>

    [ Upstream commit d07f3b081ee632268786601f55e1334d1f68b997 ]

    pstore-blk just pokes directly into the pagecache for the block
    device without going through the file operations for that by faking
    up it's own file operations that do not match the block device ones.

    As this breaks the control of the block layer of it's page cache,
    and even now just works by accident only the best thing is to just
    disable this driver.

    Fixes: 17639f67c1d6 ("pstore/blk: Introduce backend for block devices")
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Link: https://lore.kernel.org/r/20210608161327.1537919-1-hch@lst.de
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/pstore/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig
    index 8adabde685f1..328da35da390 100644
    --- a/fs/pstore/Kconfig
    +++ b/fs/pstore/Kconfig
    @@ -173,6 +173,7 @@ config PSTORE_BLK
    tristate "Log panic/oops to a block device"
    depends on PSTORE
    depends on BLOCK
    + depends on BROKEN
    select PSTORE_ZONE
    default n
    help
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 10:41    [W:2.510 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site