lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 171/800] media: st-hva: Fix potential NULL pointer dereferences
    Date
    From: Evgeny Novikov <novikov@ispras.ru>

    [ Upstream commit b7fdd208687ba59ebfb09b2199596471c63b69e3 ]

    When ctx_id >= HVA_MAX_INSTANCES in hva_hw_its_irq_thread() it tries to
    access fields of ctx that is NULL at that point. The patch gets rid of
    these accesses.

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/sti/hva/hva-hw.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/media/platform/sti/hva/hva-hw.c b/drivers/media/platform/sti/hva/hva-hw.c
    index f59811e27f51..6eeee5017fac 100644
    --- a/drivers/media/platform/sti/hva/hva-hw.c
    +++ b/drivers/media/platform/sti/hva/hva-hw.c
    @@ -130,8 +130,7 @@ static irqreturn_t hva_hw_its_irq_thread(int irq, void *arg)
    ctx_id = (hva->sts_reg & 0xFF00) >> 8;
    if (ctx_id >= HVA_MAX_INSTANCES) {
    dev_err(dev, "%s %s: bad context identifier: %d\n",
    - ctx->name, __func__, ctx_id);
    - ctx->hw_err = true;
    + HVA_PREFIX, __func__, ctx_id);
    goto out;
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 10:40    [W:2.700 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site