lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 160/800] crypto: ecdh - fix ecdh_init
    Date
    From: Hui Tang <tanghui20@huawei.com>

    [ Upstream commit 8fd28fa5046b377039d5bbc0ab2f625dec703980 ]

    NIST P192 is not unregistered if failed to register NIST P256,
    actually it need to unregister the algorithms already registered.

    Signed-off-by: Hui Tang <tanghui20@huawei.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    crypto/ecdh.c | 11 ++++++++++-
    1 file changed, 10 insertions(+), 1 deletion(-)

    diff --git a/crypto/ecdh.c b/crypto/ecdh.c
    index 4227d35f5485..e2c480859024 100644
    --- a/crypto/ecdh.c
    +++ b/crypto/ecdh.c
    @@ -183,7 +183,16 @@ static int ecdh_init(void)
    ret = crypto_register_kpp(&ecdh_nist_p192);
    ecdh_nist_p192_registered = ret == 0;

    - return crypto_register_kpp(&ecdh_nist_p256);
    + ret = crypto_register_kpp(&ecdh_nist_p256);
    + if (ret)
    + goto nist_p256_error;
    +
    + return 0;
    +
    +nist_p256_error:
    + if (ecdh_nist_p192_registered)
    + crypto_unregister_kpp(&ecdh_nist_p192);
    + return ret;
    }

    static void ecdh_exit(void)
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 10:40    [W:2.345 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site