lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 406/800] libbpf: Fix ELF symbol visibility update logic
    Date
    From: Andrii Nakryiko <andrii@kernel.org>

    [ Upstream commit 247b8634e6446dbc8024685f803290501cba226f ]

    Fix silly bug in updating ELF symbol's visibility.

    Fixes: a46349227cd8 ("libbpf: Add linker extern resolution support for functions and global variables")
    Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
    Signed-off-by: Alexei Starovoitov <ast@kernel.org>
    Link: https://lore.kernel.org/bpf/20210507054119.270888-6-andrii@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/lib/bpf/linker.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/lib/bpf/linker.c b/tools/lib/bpf/linker.c
    index 9de084b1c699..f44f8a37f780 100644
    --- a/tools/lib/bpf/linker.c
    +++ b/tools/lib/bpf/linker.c
    @@ -1780,7 +1780,7 @@ static void sym_update_visibility(Elf64_Sym *sym, int sym_vis)
    /* libelf doesn't provide setters for ST_VISIBILITY,
    * but it is stored in the lower 2 bits of st_other
    */
    - sym->st_other &= 0x03;
    + sym->st_other &= ~0x03;
    sym->st_other |= sym_vis;
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 10:40    [W:3.392 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site