lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 159/348] crypto: nitrox - fix unchecked variable in nitrox_register_interrupts
    Date
    From: Tong Tiangen <tongtiangen@huawei.com>

    [ Upstream commit 57c126661f50b884d3812e7db6e00f2e778eccfb ]

    Function nitrox_register_interrupts leaves variable 'nr_vecs' unchecked, which
    would be use as kcalloc parameter later.

    Fixes: 5155e118dda9 ("crypto: cavium/nitrox - use pci_alloc_irq_vectors() while enabling MSI-X.")
    Signed-off-by: Tong Tiangen <tongtiangen@huawei.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/cavium/nitrox/nitrox_isr.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/crypto/cavium/nitrox/nitrox_isr.c b/drivers/crypto/cavium/nitrox/nitrox_isr.c
    index 3dec570a190a..10e3408bf704 100644
    --- a/drivers/crypto/cavium/nitrox/nitrox_isr.c
    +++ b/drivers/crypto/cavium/nitrox/nitrox_isr.c
    @@ -306,6 +306,10 @@ int nitrox_register_interrupts(struct nitrox_device *ndev)
    * Entry 192: NPS_CORE_INT_ACTIVE
    */
    nr_vecs = pci_msix_vec_count(pdev);
    + if (nr_vecs < 0) {
    + dev_err(DEV(ndev), "Error in getting vec count %d\n", nr_vecs);
    + return nr_vecs;
    + }

    /* Enable MSI-X */
    ret = pci_alloc_irq_vectors(pdev, nr_vecs, nr_vecs, PCI_IRQ_MSIX);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 08:23    [W:4.174 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site