lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 138/348] media: s5p_cec: decrement usage count if disabled
    Date
    From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

    [ Upstream commit 747bad54a677d8633ec14b39dfbeb859c821d7f2 ]

    There's a bug at s5p_cec_adap_enable(): if called to
    disable the device, it should call pm_runtime_put()
    instead of pm_runtime_disable(), as the goal here is to
    decrement the usage_count and not to disable PM runtime.

    Reported-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
    Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Fixes: 1bcbf6f4b6b0 ("[media] cec: s5p-cec: Add s5p-cec driver")
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/s5p-cec/s5p_cec.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/platform/s5p-cec/s5p_cec.c b/drivers/media/platform/s5p-cec/s5p_cec.c
    index 5e80352f506b..828792b854f5 100644
    --- a/drivers/media/platform/s5p-cec/s5p_cec.c
    +++ b/drivers/media/platform/s5p-cec/s5p_cec.c
    @@ -54,7 +54,7 @@ static int s5p_cec_adap_enable(struct cec_adapter *adap, bool enable)
    } else {
    s5p_cec_mask_tx_interrupts(cec);
    s5p_cec_mask_rx_interrupts(cec);
    - pm_runtime_disable(cec->dev);
    + pm_runtime_put(cec->dev);
    }

    return 0;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 08:22    [W:2.156 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site