lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 051/800] btrfs: clear defrag status of a root if starting transaction fails
    Date
    From: David Sterba <dsterba@suse.com>

    commit 6819703f5a365c95488b07066a8744841bf14231 upstream.

    The defrag loop processes leaves in batches and starting transaction for
    each. The whole defragmentation on a given root is protected by a bit
    but in case the transaction fails, the bit is not cleared

    In case the transaction fails the bit would prevent starting
    defragmentation again, so make sure it's cleared.

    CC: stable@vger.kernel.org # 4.4+
    Reviewed-by: Qu Wenruo <wqu@suse.com>
    Reviewed-by: Anand Jain <anand.jain@oracle.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/btrfs/transaction.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- a/fs/btrfs/transaction.c
    +++ b/fs/btrfs/transaction.c
    @@ -1406,8 +1406,10 @@ int btrfs_defrag_root(struct btrfs_root

    while (1) {
    trans = btrfs_start_transaction(root, 0);
    - if (IS_ERR(trans))
    - return PTR_ERR(trans);
    + if (IS_ERR(trans)) {
    + ret = PTR_ERR(trans);
    + break;
    + }

    ret = btrfs_defrag_leaves(trans, root);


    \
     
     \ /
      Last update: 2021-07-12 10:15    [W:2.236 / U:0.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site