lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 050/800] btrfs: fix unbalanced unlock in qgroup_account_snapshot()
    Date
    From: Naohiro Aota <naohiro.aota@wdc.com>

    commit 44365827cccc1441d4187509257e5276af133a49 upstream.

    qgroup_account_snapshot() is trying to unlock the not taken
    tree_log_mutex in a error path. Since ret != 0 in this case, we can
    just return from here.

    Fixes: 2a4d84c11a87 ("btrfs: move delayed ref flushing for qgroup into qgroup helper")
    CC: stable@vger.kernel.org # 5.12+
    Reviewed-by: Qu Wenruo <wqu@suse.com>
    Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
    Reviewed-by: David Sterba <dsterba@suse.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/btrfs/transaction.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/btrfs/transaction.c
    +++ b/fs/btrfs/transaction.c
    @@ -1476,7 +1476,7 @@ static int qgroup_account_snapshot(struc
    ret = btrfs_run_delayed_refs(trans, (unsigned long)-1);
    if (ret) {
    btrfs_abort_transaction(trans, ret);
    - goto out;
    + return ret;
    }

    /*

    \
     
     \ /
      Last update: 2021-07-12 10:15    [W:4.028 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site