lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 453/700] netfilter: nf_tables: skip netlink portID validation if zero
    Date
    From: Pablo Neira Ayuso <pablo@netfilter.org>

    [ Upstream commit 534799097a777e82910f77a4f9d289c815a9a64e ]

    nft_table_lookup() allows us to obtain the table object by the name and
    the family. The netlink portID validation needs to be skipped for the
    dump path, since the ownership only applies to commands to update the
    given table. Skip validation if the specified netlink PortID is zero
    when calling nft_table_lookup().

    Fixes: 6001a930ce03 ("netfilter: nftables: introduce table ownership")
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/netfilter/nf_tables_api.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
    index 9d5ea2352965..3705086d43f5 100644
    --- a/net/netfilter/nf_tables_api.c
    +++ b/net/netfilter/nf_tables_api.c
    @@ -521,7 +521,7 @@ static struct nft_table *nft_table_lookup(const struct net *net,
    table->family == family &&
    nft_active_genmask(table, genmask)) {
    if (nft_table_has_owner(table) &&
    - table->nlpid != nlpid)
    + nlpid && table->nlpid != nlpid)
    return ERR_PTR(-EPERM);

    return table;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 10:10    [W:4.033 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site