lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 670/700] mm/z3fold: fix potential memory leak in z3fold_destroy_pool()
    Date
    From: Miaohe Lin <linmiaohe@huawei.com>

    [ Upstream commit dac0d1cfda56472378d330b1b76b9973557a7b1d ]

    There is a memory leak in z3fold_destroy_pool() as it forgets to
    free_percpu pool->unbuddied. Call free_percpu for pool->unbuddied to fix
    this issue.

    Link: https://lkml.kernel.org/r/20210619093151.1492174-6-linmiaohe@huawei.com
    Fixes: d30561c56f41 ("z3fold: use per-cpu unbuddied lists")
    Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
    Reviewed-by: Vitaly Wool <vitaly.wool@konsulko.com>
    Cc: Hillf Danton <hdanton@sina.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    mm/z3fold.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/mm/z3fold.c b/mm/z3fold.c
    index 9d889ad2bb86..56a5551f2ba8 100644
    --- a/mm/z3fold.c
    +++ b/mm/z3fold.c
    @@ -1059,6 +1059,7 @@ static void z3fold_destroy_pool(struct z3fold_pool *pool)
    destroy_workqueue(pool->compact_wq);
    destroy_workqueue(pool->release_wq);
    z3fold_unregister_migration(pool);
    + free_percpu(pool->unbuddied);
    kfree(pool);
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 10:09    [W:4.033 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site