lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 252/700] media: i2c: ccs-core: return the right error code at suspend
    Date
    From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

    [ Upstream commit 6005a8e955e4e451e4bf6000affaab566d4cab5e ]

    If pm_runtime resume logic fails, return the error code
    provided by it, instead of -EAGAIN, as, depending on what
    caused it to fail, it may not be something that would be
    recovered.

    Fixes: cbba45d43631 ("[media] smiapp: Use runtime PM")
    Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/i2c/ccs/ccs-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
    index 4505594996bd..fde0c51f0406 100644
    --- a/drivers/media/i2c/ccs/ccs-core.c
    +++ b/drivers/media/i2c/ccs/ccs-core.c
    @@ -3093,7 +3093,7 @@ static int __maybe_unused ccs_suspend(struct device *dev)
    if (rval < 0) {
    pm_runtime_put_noidle(dev);

    - return -EAGAIN;
    + return rval;
    }

    if (sensor->streaming)
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 10:09    [W:3.541 / U:0.388 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site