lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 378/700] drm/rockchip: lvds: Fix an error handling path
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 3dfa159f6b0c054eb63673fbf643a5f2cc862e63 ]

    'ret' is know to be 0 a this point. Checking the return value of
    'phy_init()' and 'phy_set_mode()' was intended instead.

    So add the missing assignments.

    Fixes: cca1705c3d89 ("drm/rockchip: lvds: Add PX30 support")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: Heiko Stuebner <heiko@sntech.de>
    Link: https://patchwork.freedesktop.org/patch/msgid/248220d4815dc8c8088cebfab7d6df5f70518438.1619881852.git.christophe.jaillet@wanadoo.fr
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/rockchip/rockchip_lvds.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c
    index 654bc52d9ff3..1a7f24c1ce49 100644
    --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c
    +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c
    @@ -499,11 +499,11 @@ static int px30_lvds_probe(struct platform_device *pdev,
    if (IS_ERR(lvds->dphy))
    return PTR_ERR(lvds->dphy);

    - phy_init(lvds->dphy);
    + ret = phy_init(lvds->dphy);
    if (ret)
    return ret;

    - phy_set_mode(lvds->dphy, PHY_MODE_LVDS);
    + ret = phy_set_mode(lvds->dphy, PHY_MODE_LVDS);
    if (ret)
    return ret;

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 10:09    [W:4.053 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site