lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 033/800] gfs2: Fix error handling in init_statfs
    Date
    From: Andreas Gruenbacher <agruenba@redhat.com>

    commit 5d49d3508b3c67201bd3e1bf7f4ef049111b7051 upstream.

    On an error path, init_statfs calls iput(pn) after pn has already been put.
    Fix that by setting pn to NULL after the initial iput.

    Fixes: 97fd734ba17e ("gfs2: lookup local statfs inodes prior to journal recovery")
    Cc: stable@vger.kernel.org # v5.10+
    Reported-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
    Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/gfs2/ops_fstype.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/fs/gfs2/ops_fstype.c
    +++ b/fs/gfs2/ops_fstype.c
    @@ -687,6 +687,7 @@ static int init_statfs(struct gfs2_sbd *
    }

    iput(pn);
    + pn = NULL;
    ip = GFS2_I(sdp->sd_sc_inode);
    error = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0,
    &sdp->sd_sc_gh);

    \
     
     \ /
      Last update: 2021-07-12 10:09    [W:3.485 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site