lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 575/700] leds: lp50xx: Put fwnode in error case during ->probe()
    Date
    From: Andy Shevchenko <andy.shevchenko@gmail.com>

    [ Upstream commit f1e1d532da7e6ef355528a22fb97d9a8fbf76c4e ]

    fwnode_for_each_child_node() bumps a reference counting of a returned variable.
    We have to balance it whenever we return to the caller.

    OTOH, the successful iteration will drop reference count under the hood, no need
    to do it twice.

    Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver")
    Cc: Dan Murphy <dmurphy@ti.com>
    Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    Signed-off-by: Pavel Machek <pavel@ucw.cz>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/leds/leds-lp50xx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
    index 06230614fdc5..401df1e2e05d 100644
    --- a/drivers/leds/leds-lp50xx.c
    +++ b/drivers/leds/leds-lp50xx.c
    @@ -490,6 +490,7 @@ static int lp50xx_probe_dt(struct lp50xx *priv)
    ret = fwnode_property_read_u32(led_node, "color",
    &color_id);
    if (ret) {
    + fwnode_handle_put(led_node);
    dev_err(priv->dev, "Cannot read color\n");
    goto child_out;
    }
    @@ -512,7 +513,6 @@ static int lp50xx_probe_dt(struct lp50xx *priv)
    goto child_out;
    }
    i++;
    - fwnode_handle_put(child);
    }

    return 0;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 10:06    [W:3.918 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site