lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 525/700] serial: 8250_omap: fix a timeout loop condition
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit d7e325aaa8c3593b5a572b583ecad79e95f32e7f ]

    This loop ends on -1 so the error message will never be printed.

    Fixes: 4bcf59a5dea0 ("serial: 8250: 8250_omap: Account for data in flight during DMA teardown")
    Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Link: https://lore.kernel.org/r/YIpd+kOpXKMpEXPf@mwanda
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/serial/8250/8250_omap.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
    index 23e0decde33e..3161d3655670 100644
    --- a/drivers/tty/serial/8250/8250_omap.c
    +++ b/drivers/tty/serial/8250/8250_omap.c
    @@ -813,7 +813,7 @@ static void __dma_rx_do_complete(struct uart_8250_port *p)
    poll_count--)
    cpu_relax();

    - if (!poll_count)
    + if (poll_count == -1)
    dev_err(p->port.dev, "teardown incomplete\n");
    }
    }
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 09:55    [W:2.631 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site